Implement BeginInsert/InsertData/EndInsert flow#26
Merged
Conversation
theory
force-pushed
the
prepare-insert
branch
2 times, most recently
from
5e0cb9a to
f3537b8
Compare
theory
force-pushed
the
prepare-insert
branch
2 times, most recently
from
64396a3 to
59d1ade
Compare
serprex
approved these changes
Nov 5, 2025
serprex
reviewed
Nov 5, 2025
theory
force-pushed
the
prepare-insert
branch
5 times, most recently
from
fecfd69 to
07073f4
Compare
theory
changed the title
PreparedInsert
theory
force-pushed
the
prepare-insert
branch
5 times, most recently
from
de366b1 to
b2df9d3
Compare
slabko
reviewed
Nov 12, 2025
theory
force-pushed
the
prepare-insert
branch
from
b2df9d3 to
a7b4c7c
Compare
theory
force-pushed
the
prepare-insert
branch
5 times, most recently
from
df8b465 to
1c3af81
Compare
Replace the old (and commented-out) code with the new `BeginInsert` / `InsertData` / `SendInsertBlock` pattern in `clickhouse-cpp`. This greatly simplifies the code, as the most of the necessary logic for creating the insert Block object and tracking the state of the insert is now handled by the Client object. Remove the old logic for unwrapping `LowCardinality` columns and fix `column_append` to properly append to those columns. This preserves traffic over the wire, I'm told. Thanks to @slabko for working out how to make that work again. Restore the logic for inserting arrays by creating a column of the proper type, then use `column_append()` to add the items to it before appending it to the `ColumnArray`. Thanks to @slabko again for the incantation to create a column of the proper type for array items. Copy the test from the old FDW and tweak it to match the other tests.
theory
force-pushed
the
prepare-insert
branch
from
1c3af81 to
26ae3f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old (and commented-out) code with the new
BeginInsert/InsertData/EndInsertpattern inclickhouse-cpp. This greatly simplifies the code, as the most of the necessary logic for creating the insert Block object and tracking the state of the insert is now handled by the Client object.Remove the old logic for unwrapping
LowCardinalitycolumns and fixcolumn_appendto properly append to those columns. This preserves traffic over the wire, I'm told. Thanks to @slabko for working out how to make that work again.Restore the logic for inserting arrays by creating a column of the proper type, then use
column_append()to add the items to it before appending it to theColumnArray. Thanks to @slabko again for the incantation to create a column of the proper type for array items.Copy the test from the old FDW, but comment out the bit working with arrays, as it has not yet been updated.